Skip to content

Update diagram in inference doc #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

Update diagram in inference doc #3945

merged 2 commits into from
Sep 23, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Sep 22, 2025 •
edited
Loading

The NJS model extraction module isn't needed at this time, so the diagram needs to be updated.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

@sjberman
Update diagram in inference doc
a857aa6 
The NJS model extraction module isn't needed at this time, so the diagram needs to be updated.
@sjberman sjberman requested review from a team as code owners September 22, 2025 20:44
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 22, 2025
bjee19
bjee19 reviewed Sep 22, 2025
View reviewed changes
@sjberman sjberman enabled auto-merge (squash) September 22, 2025 21:06
@sjberman sjberman disabled auto-merge September 23, 2025 14:36
@sjberman sjberman merged commit 4ac413b into nginx:main Sep 23, 2025
49 of 54 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 23, 2025
@sjberman sjberman deleted the docs/inference branch September 23, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjee19 bjee19 bjee19 approved these changes

@salonichf5 salonichf5 salonichf5 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjberman @bjee19 @salonichf5